Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark Merge Commits feature broken #1052

Closed
fregante opened this issue Jan 30, 2018 · 2 comments
Closed

Mark Merge Commits feature broken #1052

fregante opened this issue Jan 30, 2018 · 2 comments
Labels
bug

Comments

@fregante
Copy link
Member

fregante commented Jan 30, 2018 •
edited

GitHub changed the style

Demo page: https://github.com/babel/babel/commits/master?after=ddd40bf5c7ad8565fc990f26142f85613958a329+104

Broken code: https://github.com/sindresorhus/refined-github/blob/373164c7f6cb094db746a44acabee967c7d9aff4/source/features/mark-merge-commits-in-list.js#L8

Before

screenshot

After

screenshot

Uncaught (in promise) TypeError: Cannot read property 'prepend' of null
    at mark_merge_commits_in_list (content.js:1952)
    at enableFeature (content.js:816)
    at <anonymous>
@busches
Copy link
Member

busches commented Jan 30, 2018

As always, this change hasn't happened to GHE yet, please keep that in mind when fixing it. :)

@salmanulfarzy
Copy link
Contributor

Related: https://github.com/blog/2496-commit-together-with-co-authors

@fregante fregante mentioned this issue Feb 19, 2018
Merged
@fregante fregante mentioned this issue Feb 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
3 participants
@busches @fregante @salmanulfarzy