New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update style for merge commits #1121
Conversation
I tried putting the icon on the first line but it was hard to align it with the avatar. Not much choice other than making it 2-lines tall, but that'd make merges more visible, not less. Suggestions? |
Yeah, I get it now, but I can't think of a better way to present it either. |
Do we really need the icon at all? |
Wellllll... it is more refined |
I think it's good enough for now, better than broken. The current positioning is not offensively off. 😸 |
Fixes #1052
Test on https://github.com/babel/babel/commits/master?after=ddd40bf5c7ad8565fc990f26142f85613958a329+104
Notice: GitHub doesn't show the commit directly below the merge. The merged commit in this case is the third one, Andarist's