Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Compare" repo link should include the current branch/tag #1197

Closed
fregante opened this issue Mar 21, 2018 · 7 comments · Fixed by #2102
Closed

"Compare" repo link should include the current branch/tag #1197

fregante opened this issue Mar 21, 2018 · 7 comments · Fixed by #2102
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@fregante
Copy link
Member

fregante commented Mar 21, 2018

Issuehunt badges

  1. Visit https://github.com/BrowserSync/browser-sync/tree/client-ts
  2. Open repo tab "More" -> "Compare"
  3. See a plain master -> master comparison: https://github.com/BrowserSync/browser-sync/compare

I'd expect that to include a reference to the current branch/commit/tag, like:

BrowserSync/browser-sync@master...client-ts

Maybe there's a better way, but I'm trying to see what changed between master and whatever branch I'm looking at.

This suggestion is similar to #966, but not just between tags.

The default branch can be determined via fetch, exactly like in #1173 is available via https://github.com/sindresorhus/refined-github/blob/master/source/libs/get-default-branch.js


IssueHunt Summary

jerone jerone has been rewarded.

Sponsors (Total: $40.00)

Tips

@fregante
Copy link
Member Author

There's actually already a Compare link in the branches page, next to each branch: https://github.com/BrowserSync/browser-sync/branches

This page is one-click away for branches already, but tags don't have that.

@gjesse
Copy link

gjesse commented Jun 18, 2018

I would love to see this for tags, I frequently want to see "what changed between version x and version y" and it's always painful, particularly since the branch/tag selector dropdown in the compare view doesn't include tags or bring them up via search.

@fregante
Copy link
Member Author

That’s #966

@sindresorhus
Copy link
Member

Make sure you also send this feature request to GitHub: support@github.com

@IssueHuntBot
Copy link

@IssueHunt has funded $40.00 to this issue.


@jerone
Copy link
Contributor

jerone commented May 30, 2019

I would like to try to tackle this issue.

@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels Jun 5, 2019
@IssueHuntBot
Copy link

@sindresorhus has rewarded $36.00 to @jerone. See it on IssueHunt

  • 💰 Total deposit: $40.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $4.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Development

Successfully merging a pull request may close this issue.

5 participants