Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's make Refined GitHub faster ⚡️ #2671

Closed
6 of 7 tasks
fregante opened this issue Jan 6, 2020 · 7 comments
Closed
6 of 7 tasks

Let's make Refined GitHub faster ⚡️ #2671

fregante opened this issue Jan 6, 2020 · 7 comments
Labels
enhancement help wanted Please! ♥︎ Particularly useful features that everyone would love! small Issues that new contributors can pick up

Comments

@fregante
Copy link
Member

fregante commented Jan 6, 2020

This is a followup to #2605

In that PR I made some small changes to 3 features to avoid content jumps.

You can contribute more of these changes:

  • either by finding which features could benefit from faster loading, or
  • by sending a PR with those changes.

Some features could just benefit from some minimal caching, others need element-ready

Here are some:

  • batch-open-all ("Open all" dropdown added late)
  • pr-filters ("Status" dropdown added late, also because the value isn't cached)
  • clean-issue-filters
  • default-branch-button
  • latest-tag-button
  • hide-zero-packages
  • ... find more!

If you want to send PRs, please send one per feature.

@fregante fregante added enhancement help wanted under discussion Please! ♥︎ Particularly useful features that everyone would love! labels Jan 6, 2020
@fregante fregante changed the title Faster features / avoid content jumps ⚡️ Let's make Refined GitHub faster Jan 6, 2020
@fregante
Copy link
Member Author

fregante commented Jan 7, 2020

Here's what it takes to make a feature appear faster: 860da06

- const branchSelector = select('#branch-select-menu')!;
+ const branchSelector = (await elementReady('#branch-select-menu'))!;

...

- load: features.onAjaxedPages,
+ load: features.nowAndOnAjaxedPages,

@fregante

This comment has been minimized.

@sindresorhus

This comment has been minimized.

@fregante

This comment has been minimized.

@sindresorhus

This comment has been minimized.

@yakov116
Copy link
Member

yakov116 commented Sep 6, 2020

Closed for housekeeping purposes?

@fregante
Copy link
Member Author

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted Please! ♥︎ Particularly useful features that everyone would love! small Issues that new contributors can pick up
Development

No branches or pull requests

4 participants