Hide-markdown-diff not hiding all changed

[privatenumber]

Description

The hide-markdown-diff is not hiding all changes in the final result preview, and effectively shows an inaccurate result.

My changes

Before

> _💁‍♀️ Protip: Use the minify plugin in-place of the loader to transpile your JS_
>
> The `target` option tells _esbuild_ that it can use newer JS syntax to perform better minification. If you're not using TypeScript or any syntax unsupported by Webpack, you can also leverage this as a transpilation step. It will be faster because there's less files to work on and will produce a smaller output because the polyfills will only be bundled once for the entire build instead of per file.

After

#### _💁‍♀️ Protip: Use the minify plugin in-place of the loader to transpile your JS_
The `target` option tells _esbuild_ that it can use newer JS syntax to perform better minification. If you're not using TypeScript or any syntax unsupported by Webpack, you can also leverage this as a transpilation step. It will be faster because there's less files to work on and will produce a smaller output because the polyfills will only be bundled once for the entire build instead of per file.

Screenshots

Github default preview

With "View final result" toggled

Problems

• The "Protip: ..." is duplicated
• Spacing on the first "Protip: ..." is off
• "target" is highlighted

[fregante]

If GitHub’s diff doesn’t make this easy, we have 2 options:

• drop the feature
• add a notice about its possible looseness

If we can detect a situation when this happens (e.g. if there’s a yellow diff?) we can display the message only in that case.

[cheap-glitch]

The indentation and highlighting are easy enough to get rid of, but I don't understand why the second "Protip: […]" line isn't wrapped in a <del> element. Could this be a bug in GitHub's diff algorithm?

[fregante]

Yeah that’s what I meant, the diff isn’t reliable enough and thus we need a notice. It’s not our fault

[fregante]

• "target" is highlighted

We can fix this + add a notice (that should appear on next to the buttons probably)