clean-conversation-sidebar is broken

[SimonBrandner]

Extension enabled:

Extension disabled:

Extension version: 21.4.13
FF version: 78.9.0esr

Note: Sorry if I am missing something here 😅

[SimonBrandner]

Ah, solution is to disable this:

But still seems like a bug to me. At least if I have triage access to the repo at question, I don't expect that to be hidden. Please correct me if I am wrong though

[yakov116]

Hmm looking at the code I don't think that should happen.

Are you able to copy the DOM here?

[SimonBrandner]

Here you go

[yakov116]

Thanks

I dont see the .discussion-sidebar-item selector there 😕

Can you do $('.discussion-sidebar-item') in the console (with the ext off) and copy that elements DOM?

[SimonBrandner]

Here. Thanks for looking into this, btw!

[yakov116]

https://github.com/sindresorhus/refined-github/blob/36425c2c174fe04352a29e0f886f6930c40a6738/source/features/clean-conversation-sidebar.tsx#L68

Did not fully debug but it looks like the selector here maybe .sidebar-assignee

[fregante]

Maybe this has something to do with how we detect "can user edit repo" since it's a "all or nothing" check. As you can see, you Projects section does not have a gear icon, but collaborators do:

[yakov116]

I would try to fix it. Do you have a repo you can add me on to debug?

[yakov116]

@fregante can you reenable and disable via hotfix?

[fregante]

I'm not sure I understand

[yakov116]

We commented out the line

[fregante]

What's the situation on this feature? Is it still completely broken? I think there's no difference between how it is now and "hotfixing" it

[yakov116]

Correct but hotfixing it will allow users to know it was disabled and why.

[SimonBrandner]

Thank you!