Restore clean-conversation-sidebar feature
#4445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
reviewed
Jun 6, 2021
Co-authored-by: Federico Brigante <me@fregante.com>
|
@cheap-glitch you need to take in account users with triage access only This is what I see on download-directory/download-directory.github.io#37
|
|
This PR
|
This comment has been minimized.
This comment has been minimized.
|
@fregante can you add @cheap-glitch to download-directory so he can test? |
|
Everything should work properly now (cf. new screenshots in first post), @fregante you can remove my access. Any other special cases this feature should handle? If not, I think it's done. |
|
🥳 |
|
@cheap-glitch Can you take a look at xojs/xo#338 its missing the label header. Thanks |
The "Label" heading is always hidden, except when the user can edit the sidebar. This PR doesn't change that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4238
Fixes #4258
Test URLs
Screenshots
This PR
Merged PR
Open issue with linked PR
Open issue with milestone and assignee
PR with no labels (user has triage access)
Issue with labels (user has triage access)