Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

link-to-file-in-file-history breaks when branches contain slashes #4271

Closed
Jackenmen opened this issue Apr 23, 2021 · 3 comments · Fixed by #4296
Closed

link-to-file-in-file-history breaks when branches contain slashes #4271

Jackenmen opened this issue Apr 23, 2021 · 3 comments · Fixed by #4296
Labels
bug

Comments

@Jackenmen
Copy link
Contributor

The issue from #2692 started appearing again and can be observed in the same way (quote from #2692):

Bug appears on this page: https://github.com/Cog-Creators/Red-DiscordBot/commits/V3/develop/docs/install_linux_mac.rst

Clicking any of "See object at this point in history" buttons redirects to 404 page.
@Jackenmen Jackenmen added the bug label Apr 23, 2021
@Jackenmen
Copy link
Contributor Author

It appears that there's another feature that has a similar problem though I'm not sure what it's called and it's not that important anyway since it's just visual:
image

@yakov116
Copy link
Member

Duplicate of #4196

@yakov116 yakov116 marked this as a duplicate of #4196 Apr 23, 2021
@fregante
Copy link
Member

Should be fixed by https://github.com/sindresorhus/refined-github/pull/4187/files#diff-10ea2ac1855ba73fe69bd22a445847d89960717eef20641fb46c5ddaab234ee8

@fregante fregante mentioned this issue Apr 24, 2021
Closed
@shinenelson shinenelson mentioned this issue Apr 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
3 participants
@fregante @Jackenmen @yakov116