Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow-file-renames should handle branch names with slashes, but doesn't #4196

Closed
fregante opened this issue Apr 3, 2021 · 2 comments · Fixed by #5211
Closed

follow-file-renames should handle branch names with slashes, but doesn't #4196

fregante opened this issue Apr 3, 2021 · 2 comments · Fixed by #5211

Comments

@fregante
Copy link
Member

fregante commented Apr 3, 2021

https://github.com/sindresorhus/refined-github/commits/Slash/slash?after=ee8b6422d2ddd1199f557594d03e7ee850e843f0+34&branch=Slash%2Fslash&path%5B%5D=webpack.config.ts

As a consequence of recent changes outlined in #4179 and fixed in #4193, slashed branches are not currently supported in commits pages.

#4187 might fix it.

Follows #4193

@fregante fregante changed the title follow-file-renames should handle the slashes branch, but doesn't follow-file-renames should handle branch names with slashes, but doesn't Apr 3, 2021
@ahmed2m
Copy link
Contributor

ahmed2m commented Apr 21, 2021

I'm not sure if this issue addresses this problem with default-branch-button in the commits page too.
Like with this link
https://github.com/iberianpig/fusuma/commits/feature/device_capabilities

@yakov116
Copy link
Member

No that is a different issue will also be fixed by #4187 (We made a quick fix then and we dropped too much code)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants