Keyboard shortcuts is messed up

[kidonng]

Please ensure:

• The bug is caused by Refined GitHub. It doesn't happen if I disable the extension.

Include in this issue:

• Screenshots/video/gif demonstrating the bug, if it’s visual
• Console errors, if any

Description

Press Shift + / (?), get:

Example URL

Here

Browser(s) used

Chrome

[cheap-glitch]

The shortcut doesn't even work for me (maybe because I'm on an Azerty keyboard?)

[kidonng]

// https://github.githubassets.com/assets/app/assets/modules/github/behaviors/keyboard-shortcuts.ts
document.addEventListener('keydown', (event: Event) => {
  if (!(event instanceof KeyboardEvent)) return
  if (!isShortcutAllowed(event)) return

  if (event.target instanceof Node && isFormField(event.target)) return
  // `eventToHotkeyString`: from `@github/hotkey` (https://github.com/github/hotkey)
  if (eventToHotkeyString(event) !== 'Shift+?') return
  showKeyboardShortcuts()
})

[fregante]

@cheap-glitch The shortcut is "?", not "shift+/". Try that on your keyboard

[kidonng]

Can't replicate now, closing...

[cheap-glitch]

@cheap-glitch The shortcut is "?", not "shift+/". Try that on your keyboard

On Azerty keyboards the "?" is above "," so afaik there's no way to get it without Shift.
I think https://togithub.com/github/hotkey/issues/54 is the culprit.

[fregante]

Same here. I saw it before but now it's fixed. They must have made some temporary change

[fregante]

On Azerty keyboards the "?" is above "," so afaik there's no way to get it without Shift.

Right, so press shift+,