Fix improve-shortcut-help
#5348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidonng
commented
Jan 29, 2022
| @@ -51,7 +38,7 @@ function observeShortcutModal({key, target}: KeyboardEvent): void { | |||
| return; | |||
| } | |||
|
|
|||
| const modal = select('body > details > details-dialog'); | |||
| const modal = select('body > details:not(.js-command-palette-dialog) > details-dialog'); | |||
There was a problem hiding this comment.
Without this it would match the command palette and stop working.
kidonng
commented
Jan 29, 2022
| const observer = new MutationObserver(([{target}]) => { | ||
| if (target instanceof Element && !select.exists('.js-details-dialog-spinner', target)) { | ||
| improveShortcutHelp(target); | ||
| fixKeys(target); |
There was a problem hiding this comment.
Fix #4962. The reason I "Can't replicate now" is that this feature stopped working completely as the command palette was added.
This was previously added in #1107 but it seems GitHub already separates the keys now. We just need to split ours.
fregante
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test URLs
Here
Screenshot