Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply tab size preference to more places #4966

Closed
kidonng opened this issue Oct 21, 2021 · 1 comment · Fixed by #5715
Closed

Apply tab size preference to more places #4966

kidonng opened this issue Oct 21, 2021 · 1 comment · Fixed by #5715

Comments

@kidonng
Copy link
Member

kidonng commented Oct 21, 2021

Description

#4833 is a good start but not perfect:

For the second and third points, maybe we can fetch user preference from https://github.com/settings/appearance#tab-size-heading (or look at DOM) and reference it in our code. We can use a long expire timeout since it should be a rarely-changed setting.

Tweaking the editors are just my thoughts though, it may not be trivial or worth the effort.


A bit of context about editors:

Screenshot

No response

Example URL

N/A

@fregante
Copy link
Member

Fixed in #5715

  • Tab size adjustment doesn't work for editors

If you still want this, open a new issue so it can be discussed and tracked specifically. As you mentioned:

it may not be trivial or worth the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants