-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow the user’s tab-size setting where possible #4833
Conversation
Also fixes #4806 |
[data-tab-size] { | ||
--tab-size: attr(data-tab-size); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Demo suggestion, do not resolve
[data-tab-size] { | |
--tab-size: attr(data-tab-size); | |
} | |
[data-tab-size] { | |
--tab-size: attr(data-tab-size); | |
} |
Last chance for review. Will merge within 8 hours |
@@ -1,3 +1,32 @@ | |||
/* | |||
Can't use this because attributes are strings and calc() won't cast them | |||
ttps://stackoverflow.com/a/40815884 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this file get a GHE comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GHE is mentioned in a different comment. This code is not related to GHE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this link missing a leading h
?
argh I forgot to merge this… I'll release v21.8.2 I guess 😂 |
What
show-whitespace
Test
Working natively
GitHub bugs…
GitHub ignores the user setting in comments and just sets
data-tab-size="8"
in the DOM 🤷♂️ so I will force it in this case.Review: Follow the user’s tab-size setting where possible #4833 (comment)
Inlined code:
refined-github/package.json
Lines 1 to 6 in a796273
Code block
Try editing a comment and press tab
Screenshot 1
Screenshot 2