Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fork-source-link-same-view breaks the link when the branch is new #5479

Closed
1 of 2 tasks
fregante opened this issue Mar 11, 2022 · 1 comment · Fixed by #5494
Closed
1 of 2 tasks

fork-source-link-same-view breaks the link when the branch is new #5479

fregante opened this issue Mar 11, 2022 · 1 comment · Fixed by #5494
Assignees
@fregante
Labels
bug help wanted small Issues that new contributors can pick up

Comments

@fregante
Copy link
Member

fregante commented Mar 11, 2022 •
edited

Extension version

22.2.13

Browser(s) used

Safari 15.3

Description

  1. Visit https://github.com/humphd/browser-extension-template/tree/update-deps
  2. Click "Forked from" link in the header
  3. Land on 404

We can use the info box to determine whether the fork has the branch or not.

Fork source has branch

Info box mentions the same branch as the current one

Screen Shot 2

### Fork source has no branch

Info box mentions the main branch (or anything other than the current branch)

Screen Shot 3

Include in this issue:

  • Screenshots/video/gif demonstrating the bug, if it’s visual
  • Console errors, if any
@fregante fregante added bug help wanted small Issues that new contributors can pick up labels Mar 11, 2022
@fregante fregante self-assigned this Mar 13, 2022
@fregante fregante mentioned this issue Mar 13, 2022
Merged
@kidonng
Copy link
Member

kidonng commented Mar 16, 2022

This is definitely caused by #5351 😅 I was too optimistic, it should have been more restricted.

@waldyrious waldyrious mentioned this issue Jul 3, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fregante fregante

Labels
bug help wanted small Issues that new contributors can pick up
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reliability fixes for fork-source-link-same-view refined-github/refined-github
2 participants
@fregante @kidonng