Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend forked-to and fork-source-link-same-view to entire repo #5351

Merged
merged 5 commits into from Feb 1, 2022

Conversation

kidonng
Copy link
Member

@kidonng kidonng commented Jan 29, 2022

Most pages of forks and parents are interchangeable, except for issues and PRs.

Enforcing too many limits is unnecessary and useful-not-found-page would help if something does go wrong.

Test URLs

Screenshot

});
}

if (!isFilePath() || await doesFileExist(sameViewUrl)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this trigger an extra request for every fork page we visit? I'm surprised we went with this solution.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did since it's a tiny request and we did not want 404s

@cheap-glitch cheap-glitch changed the title Extend forked-to and fork-source-link-same-view to entrie repo Extend forked-to and fork-source-link-same-view to entire repo Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants