Rethink latest-tag-button

[fregante]

The new React-based views mentioned in #6152, no longer have enough space to show latest-tag-button

Essentially the old view is only show on isRepoRoot

What do we do with this feature? It was initially added to:

• inform the user that they're looking at a version of the readme that doesn't match the latest version
• see what commits haven't yet been released

Questions:

• does it really belong in that area of the screen?
• do we really need to show it in every folder and every file?
• is there a better way to communicate this information?

[fregante]

The feature also lets you:

• see the current view on the latest tag
• compare the latest tag to the latest version on main (which is a bit awkward on non-main branches)

I wonder if we can reduce it to:

• "see latest published version" link
• "see unreleased commits" link
• count unreleased commits

This would let us split and reposition the feature. We don't need to show the latest version on every page.

[fregante]

Here's my suggestion, I think it's a more direct solution to the original issue. The only missing part is that it requires 2 more clicks (without pageloads) to open "the same view, but in the latest tag." That's something I think is relatively rarely needed 🤔

unreleased-commits

• Shows: Whether there are unreleased commits
• Shows: How many commits are unreleased (if possible)
• Action: List unreleased commits (compare view)

Resolves:

• space issues: it's less than 60px wide
• sizing: we can finally drop btn-sm
• confusing state: it no longer confusingly shows the current tag in every single page

Missing:

• The exact tag: it can appear in the tooltip

• A link to the "tree" view of the tag: still available in +2 clicks in the dropdown

  

[fregante]

Something to note: unreleased-commits would only appear on the default branch; not on tags, not on commits, not on other branches. The feature would exclusively say:

Hey you're looking at a newer version than what's published

This would also leave space for:

• Add way to switch between "tag view" and "browse view" #6499

[kidonng]

Maybe we should just merge it with the branch/tag picker:

On default branch

TODO

On non-default branch

Do nothing, as mentioned:

• compare the latest tag to the latest version on main (which is a bit awkward on non-main branches)

On latest tag

Homepage

File browser

Same as above, the issue is where to put the compare button

On non-latest tag

Homepage

How to go to latest tag

1. Open picker
2. Select tag tab
3. Click the first item

So it's 1 click -> 3 clicks

Unlike in file browser, it doesn't automatically open the tag tab, maybe we can automate that and save one click

File browser

How to go to latest tag:

1. Open picker
2. Click the first item

So it's 1 click -> 2 clicks, barely a difference

[fregante]

How to go to latest tag

I think we need to de-emphasize the importance/frequency of this action and the necessity to know the latest tag on every single page.

I think unreleased-commits would bring the benefits we had initially wanted without filling the UI with unnecessary information.

This is why I suggest dropping latest-tag-button and adding a new, focused feature.

How to go to latest tag

1. Open picker
2. Select tag tab
3. Click the first item

This is good enough for me, requires no features/changes from us.

[kidonng]

I think we need to de-emphasize the importance/frequency of this action and the necessity to know the latest tag on every single page.

My proposal is about not losing any current info, of course cutting down them is welcome