file-age-color also runs on issues and PR tab

[Katsute]

Description

The new file age color feature also changes colors on issue and PR tabs.

How to replicate the issue + URL

1. This repo https://github.com/refined-github/refined-github/
2. Press issue or pr tab

Only happens if you go directly from a file page to a issue/pr tab, moving from issue to pr tab doesn't have this issue.

Extension version

23.2.20

Browser(s) used

Google Chrome 110.0.5481.104 x64

[fregante]

How could that be possible? We're using the correct page filters and signal 🤔

refined-github/source/features/file-age-color.tsx

Lines 18 to 30 in 60ac04e

	function init(signal: AbortSignal): void {
	observe([
	'.js-navigation-item relative-time', // TODO: Drop old view in mid 2023
	'.react-directory-commit-age > [title]',
	], addHeatIndex, {signal});
	}
	void features.add(import.meta.url, {
	include: [
	pageDetect.isRepoTree,
	],
	init,
	});

It feels like I broke something important or it has always been broken and this feature just made it visible

[Katsute]

Might be a timing issue caused by the SPA. Is it possible the feature is running after the DOM change but before the URL change? This might explain why going to another tab right after doesn't have this issue.

[fregante]

timing issue caused by the SPA

Last related change in 23.2.1:

• Reduce content shift on navigation #6267

[Shinigami92]

Oh, I thought that was a feature 👀
I just wanted to report the bug that it doesn't load when you directly go to issue or PRs e.g. by reloading the page
You first need to load the Code tab and then navigate to issue/PR

[5HT2]

I also honestly thought this was an intentional feature. If there could be an option to also enable this for issues / pull requests I'd greatly appreciate that!