pr-base-commit errors in attempting to remove a non-existent automerge message

[DanielMiao1]

Description

Currently, the pr-base-commit feature attempts to remove (view source) the "Merging can be performed automatically" message (see figure 1) from the bottom of a pull request conversations page without verifying the existence of the message.

As the message is only shown to users with sufficient privileges to merge the pull request, the code fails with a warning-level Error <span class="status-meta"> and an Error: Expected node matching "Merging can be performed automatically.", found {actual_content} (see figure 2) when a pull request is viewed by a user who does not have sufficient privileges.

How to replicate the issue + URL

1. Visit an open, non-blocked, and non-draft pull request that you do not have sufficient privileges to merge and is behind the base branch, such as update sitemap for commit 382e86b DanielMiao1/test#8
2. The error is raised in the browser console (see figure 2).
    

Figure 1
The Merging can be performed automatically message shown to privileged users before its removal

 

Figure 2
The console error when viewing the page without sufficient privileges

Extension version

23.5.10

Browser(s) used

all supported browsers

[fregante]

without verifying the existence of the message.

The message you see is the exactly the verification: the text doesn’t match, so it throws an error 😉

Solution:

• silence error
• have the text appear on two lines instead of that