Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr-base-commit does not append a trailing whitespace to the injected message when needed #6651

Closed
DanielMiao1 opened this issue May 14, 2023 · 1 comment · Fixed by #6703
Closed
Labels

Comments

@DanielMiao1
Copy link
Contributor

Description

The code for the pr-base-commit feature that injects the "x commits behind (base commit: 1234567)" message in the addInfo function does not currently account for an Only those with write access ... can merge pull requests message, causing a missing whitespace character before the word "Only" (see figure 1).

How to replicate the issue + URL

  1. Navigate to an open, non-draft, and non-blocked pull request behind the base branch that you do not have permission to merge (in order to display the write-access message) such as update sitemap for commit 79b76c6 DanielMiao1/test#6
  2. Observe the issue:
     

Figure 1
figure1

Extension version

23.5.10

Browser(s) used

all supported browsers

@fregante
Copy link
Member

Thank you, one issue is enough: #6650

@fregante fregante closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants