Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening an actions run causes duplicate repo-avatars #6790

Closed
uncenter opened this issue Jul 26, 2023 · 6 comments · Fixed by #6791
Closed

Opening an actions run causes duplicate repo-avatars #6790

uncenter opened this issue Jul 26, 2023 · 6 comments · Fixed by #6791
Labels
bug disabled via hotfix A label to remind us to remove the feature from yolo

Comments

@uncenter
Copy link

uncenter commented Jul 26, 2023

Description

After going to a specific actions run in a repository, like user/repo/actions/runs/<run>, clicking on any other repository tabs (and some links) causes the avatar to be duplicated.

image

a.mov

How to replicate the issue + URL

  1. Go to https://github.com/fregante/GhostText/actions/runs/5538535691?pr=289 or any other Actions run.
  2. Click the any other tab without reloading, like the Issues or Code tabs.
  3. See duplicated avatars!

Extension version

23.7.25

Browser(s) used

Firefox

@uncenter uncenter added the bug label Jul 26, 2023
@fregante fregante added the disabled via hotfix A label to remind us to remove the feature from yolo label Jul 26, 2023
@fregante
Copy link
Member

Thank you! I’ll disable the feature in a moment 🥲

fregante added a commit to refined-github/yolo that referenced this issue Jul 26, 2023
@uncenter
Copy link
Author

If/when it gets renabled, I think we should consider maybe redesigning it somehow... the redesigned GitHub layout makes the avatar look awkward next to the GitHub logo.

@fregante
Copy link
Member

fregante commented Jul 26, 2023

Redesigned how? I don't think we can do much about it; however you slice it, it's a yet another blob on the header. In the last PR I made it smaller and closer to the repo owner name, but other than that I don’t think we can really "redesign" it. See #6788 (comment)

@uncenter
Copy link
Author

Redesigned how? I don't think we can do much about it; however you slice it, it's a yet another blob on the header. In the last PR I made it smaller and closer to the repo owner name, but other than that I don’t think we can really "redesign" it. See #6788 (comment)

I'm not entirely sure either. I've been thinking about it and if I have any ideas for improvements I'll make a PR.

@github-actions
Copy link

To maintainers: Disable the hotfix by adding 23.7.28 to https://github.com/refined-github/yolo/edit/main/broken-features.csv

fregante added a commit to refined-github/yolo that referenced this issue Jul 28, 2023
@fregante
Copy link
Member

This could be an option but I think it's a bit much

Screenshot 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug disabled via hotfix A label to remind us to remove the feature from yolo
Development

Successfully merging a pull request may close this issue.

2 participants