Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wait-for-checks is missing or it does not merge the PR #6914

Closed
johnmaguire opened this issue Sep 15, 2023 · 2 comments · Fixed by #7249
Closed

wait-for-checks is missing or it does not merge the PR #6914

johnmaguire opened this issue Sep 15, 2023 · 2 comments · Fixed by #7249
Labels
bug disabled via hotfix A label to remind us to remove the feature from yolo help wanted

Comments

@johnmaguire
Copy link

Description

Screenshot 2023-09-15 at 12 22 00 PM
Screen.Recording.2023-09-15.at.12.20.56.PM.mov

How to replicate the issue + URL

  • Enable wait-for-checks
  • Find a PR with running status checks
  • Click "Squash and merge"
  • Expected checkbox to wait for status checks to complete does not appear

Extension version

23.9.7

Browser(s) used

Firefox
@fregante
Copy link
Member

Thanks for the report. I noticed this as well, it's likely because GitHub has become (even more) unreliable in updating the checks UI on the page, so a rewrite is now required:

I should probably disable the feature via hotfix

@fregante fregante added the disabled via hotfix A label to remind us to remove the feature from yolo label Sep 15, 2023
@fregante fregante changed the title wait-for-checks is not working wait-for-checks is not working Sep 15, 2023
@fregante fregante changed the title wait-for-checks is not working wait-for-checks is missing or it does not merge the PR Sep 15, 2023
fregante added a commit to refined-github/yolo that referenced this issue Sep 15, 2023
@fregante
Disable wait-for-checks
dfe104f 
refined-github/refined-github#6914
@fregante fregante mentioned this issue Nov 16, 2023
Closed
@fregante fregante mentioned this issue Feb 5, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

To maintainers: Disable the hotfix by adding 24.2.5 to https://github.com/refined-github/yolo/edit/main/broken-features.csv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug disabled via hotfix A label to remind us to remove the feature from yolo help wanted
Milestone
No milestone
2 participants
@johnmaguire @fregante