-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance issue on PRs with lots of changes #7116
Comments
This comment was marked as outdated.
This comment was marked as outdated.
After testing a bit more I'm noticing that the difference in performance is much more noticeable on Firefox than Chrome so maybe there's something to dig into there (I thought I had written Firefox in my OP but i didn't, my bad 🤦 ). @fregante could you tell me if you notice the same thing? If not I can try to use the profiler and send the recording. |
The question is: do you notice the same slowness after disabling Refined GitHub? |
Nope, disabling Refined GitHub makes the issue go away, but I agree that on Chrome it's way less noticeable 😅 Also I think having the files sidebar opened on a PR makes it worse but im not 100% sure. |
This comment was marked as duplicate.
This comment was marked as duplicate.
After bisection (Identify feature) |
Actually for what OP has linked Both of them uses CSS animation based observers. |
locked-issue is not enabled on the files tab so that's unlikely to be the cause. I'll check if there's some loop in the code of the observer but otherwise it should be lightweight. Are you on Firefox too? Did you enable the has-selector option in about:config? |
It actually confirms the hypothesis more. When you load the files tab directly, there's no perf issue; when you load another tab then switch to files, it's very slow. I tested the latter during bisection. |
Sounds related to: |
This comment was marked as resolved.
This comment was marked as resolved.
I can reproduce this as well. Disabling |
This comment was marked as resolved.
This comment was marked as resolved.
FWIW, I did not have |
Maybe some of us are talking about one performance problem and some of us another. Quite the coincidence if there are two of them on the Files changed tab in Firefox at the same time 😄 For me, the Files changed is sluggish in general, but especially when I try to add a PR comment – it takes tens of seconds for the comment box to appear. |
can confirm this slowdown also happens on job log. disabling using:
|
That's because disabling Side note: I must say Firefox' dev tools are junk-level. |
The problem disappears for me when I disable I'm disabling the feature via hotfix for now, this is a bad bug for Firefox users. It seems that it's somehow triggering GitHub's custom-elements events and even on the Conversation tab of that PR |
I haven't investigated further, but when I'm on the PR |
I'm still seeing huge slowdowns on #6954 in Safari, even with |
I've been seeing this while reviewing cooljeanius/Flight_Freedom#18 on Firefox 121... I'm wondering if it has something to do with me also having NoScript installed? Firefox has been sending me alternating "an extension is slowing down your browser" warnings about both Refined GitHub and NoScript, so I'm wondering if there's some sort of interaction between the two... |
I'll accept a PR that disables those 4 features on I also opened another ticket for a longer-term solution: #7192 |
Judging by the poor performance seen on the Turns out that letting the CSS handle it might not actually be the most efficient solution. |
Just in case it is useful, for me Firefox 122.0 (64-bit), |
Here |
I'm having issues too. MAC OS: Sonama (MacMini 3 GHz 6-Core Intel Core i5) Disabling show-whitespace, quick-comment-edit, and quick-review-comment-deletion appears to have helped too but didn't fix the issue just improves it. When I disable the extension it opens faster. Fun fact: When was I using MacOS Ventura I didn't have this issue, or it updated the extension on the same time |
I could not open a diff at all on some PR until I turned off |
Done |
To maintainers: Disable the hotfix by adding |
I'm closing this issue for now, I'll release a new version after #7313 is merged. |
Description
I wish I had a specific feature to point to, but since this issue seems to appear only when "first" loading a PR
/files
page, it was tricky for me to find anything conclusive with the troubleshooting tool. I'd be happy to run more diagnostics if necessary.Basically, loading a big PR (+1179 -117 across 58 files on the example one) results in pretty slow loading/rendering and sometimes makes Firefox hang completely.
CleanShot.2023-11-27.at.17.27.02.mp4
How to replicate the issue + URL
Go to eramdam/BetterTweetDeck#519 then load the
Files changed
tabHere are my settings:
Refined GitHub options.json
Extension version
23.11.15.1433
Browser(s) used
Firefox 120.0 on macOS 14.1.1
The text was updated successfully, but these errors were encountered: