small-user-avatars showing wrong avatars on commit history/details

[dgw]

Description

GitHub appears to have added the user-mention class to commit-author links in places like the commit detail page and commit list. Refined GitHub now adds an incorrect, redundant small avatar if that feature is turned on:

In the above example, the avatar for "gw" is shown instead of "dgw". RGH expects a user-mention to start with @ and trims the first character, but the commit-author link type does not include @.

refined-github/source/features/small-user-avatars.tsx

Line 25 in a0381ca

const username = link.textContent.slice(1);

<a class="commit-author user-mention" title="View all commits by dgw" data-hovercard-type="user"
  data-hovercard-url="/users/dgw/hovercard" data-octo-click="hovercard-link-click"
  data-octo-dimensions="link_type:self" href="/sopel-irc/sopel/commits?author=dgw">dgw</a>

How to replicate the issue + URL

I noticed it at sopel-irc/sopel@120477f but this happens anywhere a commit is shown (including /:user/:repo/commits/:refname and at the top of /:user/:repo)

Extension version

23.12.1

Browser(s) used

Chrome 119

[XDelta]

Can confirm I am seeing this as well.
XDelta is being adjusted to Delta and showing an additonal and incorrect user icon

[fregante]

It looks like the added the user-mention class to an element that isn't a mention 😩

I'll hot fix the feature to disable it.

[dgw]

It looks like the added the user-mention class to an element that isn't a mention 😩

Yeah, this change to GH's markup makes no sense to me. If RGH has the ability to treat .user-mention and .user-mention.commit-author differently, that could be a way around this. (Does something like .user-mention:not(.commit-author) work with the selector-observer helper?)

[fregante]

Yes I think that would cover it.

[dgw]

Bootstrapped Node locally so I could test the change locally, and opened #7139 with the results. Hope it's helpful! (I just have to figure out linting + fix the code style.)

[github-actions]

To maintainers: Disable the hotfix by adding 23.12.6 to https://github.com/refined-github/yolo/edit/main/broken-features.csv