Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closing-remarks not showing on new computer? #7370

Closed
aryairani opened this issue May 22, 2024 · 12 comments
Closed

closing-remarks not showing on new computer? #7370

aryairani opened this issue May 22, 2024 · 12 comments

Comments

@aryairani
Copy link

Not sure if it's a local configuration error, a repo issue, or a regression?

Not sure if the personal access token is required, but I have added one and reloaded the page.
image

@fregante
Copy link
Member

Same situation as you, and I see it here:

https://togithub.com/refined-github/refined-github/pull/3689

Screenshot 2024-05-23 at 15 01 22

@fregante fregante closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2024
@aryairani
Copy link
Author

Hm.. So how do I fix it? :)

I didn't know it was displayed at the bottom of the page, I thought it was at the top:

image

Did it used to display something at the top of the page when it doesn't appear in any releases yet?

Or did something change about how pre-releases are shown?

I have this
image
image

but seeing it at the bottom of a long page isn't very helpful; it should be mentioned at the top IMO.

@aryairani
Copy link
Author

The PR is included in a pre-release, so I'm surprised that's not mentioned at the top.

@aryairani
Copy link
Author

unisonweb/unison#5002

@fregante
Copy link
Member

fregante commented May 23, 2024

The feature works correctly, read the message: The merge commit doesn't appear in any tags. This appears to be accurate. We just follow what GitHub tells us and there's no tag here, under the commit title: unisonweb/unison@8a27961

@aryairani
Copy link
Author

It does show me a tag under the commit title at the link you provided:
image
the trunk-build tag

@aryairani
Copy link
Author

aryairani commented May 23, 2024

Sorry, I see the links but I'm not sure what you're telling me with them.

Do you mean that the behavior changed in February with #7243?

Looking at that PR I'm not sure what I'm meant to take away from it. My tag is not called nightly. I guess I should be looking at the regex and seeing that because my tag doesn't have a . in it, then it's also hidden, as of February of this year?

Or did you mean this?

Also it might just be a Refined GitHub cache issue

And if so, how do I clear the cache?

@fregante
Copy link
Member

Yes, only version tags are counted now.

The cache can be cleared from the extensions Options page

@aryairani
Copy link
Author

Alright. In case anyone else asks, I recommend just telling them "The behavior of closing-remarks was changed in February" instead of closing the ticket with no explanation. 🙏

@fregante
Copy link
Member

When you opened this issue, you disregarded the template picker. If you had picked the bug report and provided the URL as required, I'd have been quick to tell you that there isn't any usable tag on that PR. Also I responded to every one of your comment, so don't come here saying I closed the issue without explanation.

@aryairani
Copy link
Author

aryairani commented May 28, 2024

Sorry, I meant that you closed the issue without explanation. After you closed the issue without explanation, I asked for more explanation and you did respond, which I appreciate. And after a lot of confusing back-and-forth I determined, by reading the source code, how and when the behavior changed in February, that your definition of "usable tag" changed in February.

With regard to the template picker, it's not true that I disregarded anything. I chose "Ask a question or open a discussion", which doesn't have a template and doesn't ask for a URL.

image

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants