update workflows for lib.install #5002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
These two workflows used
pullto install libraries, which we don't allow anymore; and a caching issue allowed them to slip through CI, but the pre-release workflow was failing unnoticed, which meant that trunk binary builds have not been updating for the past few days.Implementation details
I switched from
pulltolib.install. Separately I also updated README to show a badge for the pre-release workflow:Closes #5000
Test coverage
I ran a manual pre-release workflow on this branch, which passed.
https://github.com/unisonweb/unison/actions/runs/9199316292
Loose ends
This PR fixes the workflows but doesn't fix the caching issue that allowed them to slip through CI.
https://github.com/unisonweb/unison/actions/runs/9197680977 (CI)
https://github.com/unisonweb/unison/actions/runs/9198203478 (pre-release)