Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop add from feature names #1720

Merged
merged 1 commit into from Jan 15, 2019
Merged

Drop add from feature names #1720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 7 additions & 4 deletions source/background.js
View file
Open in desktop
Expand Up @@ -13,10 +13,13 @@ new OptionsSync().define({
},
migrations: [
options => {
options.disabledFeatures = options.disabledFeatures.replace('display-issue-suggestions', ''); // #1611
options.disabledFeatures = options.disabledFeatures.replace('open-all-selected', 'batch-open-issues'); // #1402
options.disabledFeatures = options.disabledFeatures.replace('copy-file-path', ''); // #1628
options.disabledFeatures = options.disabledFeatures.replace('bypass-checks-travis', 'bypass-checks'); // #1693
options.disabledFeatures = options.disabledFeatures
.replace('display-issue-suggestions', '') // #1611
.replace('open-all-selected', 'batch-open-issues') // #1402
.replace('copy-file-path', '') // #1628
.replace('bypass-checks-travis', 'bypass-checks') // #1693
.replace(/^add-(.+)-to-(profile|comments|comment-fields|emojis)$/, '$2-$1') // #1719
.replace(/^add-/, ''); // #1719
},
OptionsSync.migrations.removeUnused
]
Expand Down
50 changes: 25 additions & 25 deletions source/content.js
View file
Open in desktop
Expand Up @@ -2,21 +2,21 @@ import select from 'select-dom';
import 'webext-dynamic-content-scripts';

import './features/useful-not-found-page';
import './features/add-trending-menu-item';
import './features/trending-menu-item';
import './features/hide-useless-newsfeed-events';
import './features/more-dropdown';
import './features/add-releases-tab';
import './features/releases-tab';
import './features/remove-projects-tab';
import './features/focus-confirmation-buttons';
import './features/add-keyboard-shortcuts-to-comment-fields';
import './features/comment-fields-keyboard-shortcuts';
import './features/hide-navigation-hover-highlight';
import './features/monospace-textareas';
import './features/add-selection-in-new-tab';
import './features/selection-in-new-tab';
import './features/hide-comments-faster';
import './features/mark-unread';
import './features/open-all-notifications';
import './features/copy-on-y';
import './features/add-profile-hotkey';
import './features/profile-hotkey';
import './features/make-discussion-sidebar-sticky';
import './features/close-out-of-view-modals';
import './features/improve-shortcut-help';
Expand All @@ -27,56 +27,56 @@ import './features/hide-own-stars';
import './features/infinite-scroll';
import './features/hide-empty-meta';
import './features/remove-upload-files-button';
import './features/add-title-to-emojis';
import './features/emojis-title';
import './features/shorten-links';
import './features/linkify-urls-in-code';
import './features/add-download-folder-button';
import './features/download-folder-button';
import './features/linkify-branch-refs';
import './features/batch-open-issues';
import './features/hide-useless-comments';
import './features/navigate-pages-with-arrow-keys';
import './features/make-headers-sticky';
import './features/add-yours-menu-item';
import './features/add-commented-menu-item';
import './features/yours-menu-item';
import './features/commented-menu-item';
import './features/sort-issues-by-update-time'; // Must be after add-yours-menu-item + add-commented-menu-item
import './features/hide-readme-header';
import './features/add-branch-buttons';
import './features/add-diff-view-without-whitespace-option';
import './features/add-ci-link';
import './features/add-milestone-navigation';
import './features/branch-buttons';
import './features/diff-view-without-whitespace-option';
import './features/ci-link';
import './features/milestone-navigation';
import './features/sort-milestones-by-closest-due-date'; // Needs to be after add-milestone-navigation
import './features/add-star-repo-hotkey';
import './features/add-toggle-files-button';
import './features/star-repo-hotkey';
import './features/toggle-files-button';
import './features/scroll-to-top-on-collapse';
import './features/add-delete-fork-link';
import './features/delete-fork-link';
import './features/fix-squash-and-merge-title';
import './features/fix-squash-and-merge-message';
import './features/open-ci-details-in-new-tab';
import './features/wait-for-build';
import './features/hide-inactive-deployments';
import './features/add-pull-request-hotkey';
import './features/add-quick-review-buttons';
import './features/pull-request-hotkey';
import './features/quick-review-buttons';
import './features/linkify-issues-in-titles';
import './features/embed-gist-inline';
import './features/extend-status-labels';
import './features/highlight-closing-prs-in-open-issues';
import './features/op-labels';
import './features/add-time-machine-links-to-comments';
import './features/add-jump-to-bottom-link';
import './features/add-filter-comments-by-you';
import './features/comments-time-machine-links';
import './features/jump-to-bottom-link';
import './features/filter-comments-by-you';
import './features/hide-issue-list-autocomplete';
import './features/exclude-filter-shortcut';
import './features/show-recently-pushed-branches-on-more-pages';
import './features/add-create-release-shortcut';
import './features/add-patch-diff-links';
import './features/add-swap-branches-on-compare';
import './features/create-release-shortcut';
import './features/patch-diff-links';
import './features/swap-branches-on-compare';
import './features/reactions-avatars';
import './features/show-names';
import './features/mark-merge-commits-in-list';
import './features/prev-next-commit-buttons';
import './features/preserve-whitespace-option-in-nav';
import './features/extend-diff-expander';
import './features/add-gists-link-to-profile';
import './features/profile-gists-link';
import './features/show-followers-you-know';
import './features/show-user-top-repositories';
import './features/set-default-repositories-type-to-sources';
Expand Down
2 changes: 1 addition & 1 deletion source/features/add-branch-buttons.js → source/features/branch-buttons.js
View file
Open in desktop
Expand Up @@ -118,7 +118,7 @@ async function init() {
}

features.add({
id: 'add-branch-buttons',
id: 'branch-buttons',
include: [
features.isRepo
],
Expand Down
2 changes: 1 addition & 1 deletion source/features/add-ci-link.js → source/features/ci-link.js
View file
Open in desktop
Expand Up @@ -50,7 +50,7 @@ async function init() {
}

features.add({
id: 'add-ci-link',
id: 'ci-link',
include: [
features.isRepo
],
Expand Down
2 changes: 1 addition & 1 deletion ...d-keyboard-shortcuts-to-comment-fields.js → ...ures/comment-fields-keyboard-shortcuts.js
View file
Open in desktop
Expand Up @@ -64,6 +64,6 @@ function init() {
}

features.add({
id: 'add-keyboard-shortcuts-to-comment-fields',
id: 'comment-fields-keyboard-shortcuts',
init
});
2 changes: 1 addition & 1 deletion source/features/add-commented-menu-item.js → source/features/commented-menu-item.js
View file
Open in desktop
Expand Up @@ -21,7 +21,7 @@ function init() {
}

features.add({
id: 'add-commented-menu-item',
id: 'commented-menu-item',
include: [
features.isGlobalIssueSearch,
features.isGlobalPRSearch
Expand Down
2 changes: 1 addition & 1 deletion ...res/add-time-machine-links-to-comments.js → ...e/features/comments-time-machine-links.js
View file
Open in desktop
Expand Up @@ -28,7 +28,7 @@ function init() {
}

features.add({
id: 'add-time-machine-links-to-comments',
id: 'comments-time-machine-links',
include: [
features.isPRConversation,
features.isIssue
Expand Down
2 changes: 1 addition & 1 deletion ...e/features/add-create-release-shortcut.js → source/features/create-release-shortcut.js
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@ function init() {
}

features.add({
id: 'add-create-release-shortcut',
id: 'create-release-shortcut',
include: [
features.isReleasesOrTags
],
Expand Down
2 changes: 1 addition & 1 deletion source/features/add-delete-fork-link.js → source/features/delete-fork-link.js
View file
Open in desktop
Expand Up @@ -23,7 +23,7 @@ function init() {
}

features.add({
id: 'add-delete-fork-link',
id: 'delete-fork-link',
include: [
features.isPRConversation
],
Expand Down
2 changes: 1 addition & 1 deletion ...dd-diff-view-without-whitespace-option.js → ...es/diff-view-without-whitespace-option.js
View file
Open in desktop
Expand Up @@ -45,7 +45,7 @@ function init() {
}

features.add({
id: 'add-diff-view-without-whitespace-option',
id: 'diff-view-without-whitespace-option',
include: [
features.isRepo
],
Expand Down
2 changes: 1 addition & 1 deletion ...ce/features/add-download-folder-button.js → source/features/download-folder-button.js
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@ function init() {
}

features.add({
id: 'add-download-folder-button',
id: 'download-folder-button',
include: [
features.isRepoTree
],
Expand Down
2 changes: 1 addition & 1 deletion source/features/add-title-to-emojis.js → source/features/emojis-title.js
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@ function init() {
}

features.add({
id: 'add-title-to-emojis',
id: 'emojis-title',
load: features.onAjaxedPages,
init
});
2 changes: 1 addition & 1 deletion ...ce/features/add-filter-comments-by-you.js → source/features/filter-comments-by-you.js
View file
Open in desktop
Expand Up @@ -21,7 +21,7 @@ function init() {
}

features.add({
id: 'add-filter-comments-by-you',
id: 'filter-comments-by-you',
include: [
features.isIssueList
],
Expand Down
2 changes: 1 addition & 1 deletion source/features/add-jump-to-bottom-link.js → source/features/jump-to-bottom-link.js
View file
Open in desktop
Expand Up @@ -21,7 +21,7 @@ function init() {
}

features.add({
id: 'add-jump-to-bottom-link',
id: 'jump-to-bottom-link',
include: [
features.isIssue,
features.isPRConversation
Expand Down
2 changes: 1 addition & 1 deletion source/features/add-milestone-navigation.js → source/features/milestone-navigation.js
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@ function init() {
}

features.add({
id: 'add-milestone-navigation',
id: 'milestone-navigation',
include: [
features.isMilestone
],
Expand Down
2 changes: 1 addition & 1 deletion source/features/add-patch-diff-links.js → source/features/patch-diff-links.js
View file
Open in desktop
Expand Up @@ -20,7 +20,7 @@ function init() {
}

features.add({
id: 'add-patch-diff-links',
id: 'patch-diff-links',
include: [
features.isCommit
],
Expand Down
2 changes: 1 addition & 1 deletion source/features/add-gists-link-to-profile.js → source/features/profile-gists-link.js
View file
Open in desktop
Expand Up @@ -23,7 +23,7 @@ async function init() {
}

features.add({
id: 'add-gists-link-to-profile',
id: 'profile-gists-link',
include: [
features.isUserProfile
],
Expand Down
2 changes: 1 addition & 1 deletion source/features/add-profile-hotkey.js → source/features/profile-hotkey.js
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@ function init() {
}

features.add({
id: 'add-profile-hotkey',
id: 'profile-hotkey',
load: features.onDomReady,
init
});
2 changes: 1 addition & 1 deletion source/features/add-pull-request-hotkey.js → source/features/pull-request-hotkey.js
View file
Open in desktop
Expand Up @@ -24,7 +24,7 @@ function init() {
}

features.add({
id: 'add-pull-request-hotkey',
id: 'pull-request-hotkey',
include: [
features.isPR
],
Expand Down
2 changes: 1 addition & 1 deletion source/features/add-quick-review-buttons.js → source/features/quick-review-buttons.js
View file
Open in desktop
Expand Up @@ -70,7 +70,7 @@ function init() {
}

features.add({
id: 'add-quick-review-buttons',
id: 'quick-review-buttons',
include: [
features.isPR
],
Expand Down
2 changes: 1 addition & 1 deletion source/features/add-releases-tab.js → source/features/releases-tab.js
View file
Open in desktop
Expand Up @@ -60,7 +60,7 @@ async function init() {
}

features.add({
id: 'add-releases-tab',
id: 'releases-tab',
include: [
features.isRepo
],
Expand Down
2 changes: 1 addition & 1 deletion source/features/add-selection-in-new-tab.js → source/features/selection-in-new-tab.js
View file
Open in desktop
Expand Up @@ -20,6 +20,6 @@ function init() {
}

features.add({
id: 'add-selection-in-new-tab',
id: 'selection-in-new-tab',
init
});
2 changes: 1 addition & 1 deletion source/features/add-star-repo-hotkey.js → source/features/star-repo-hotkey.js
View file
Open in desktop
Expand Up @@ -12,7 +12,7 @@ function init() {
}

features.add({
id: 'add-star-repo-hotkey',
id: 'star-repo-hotkey',
include: [
features.isRepo
],
Expand Down
2 changes: 1 addition & 1 deletion .../features/add-swap-branches-on-compare.js → source/features/swap-branches-on-compare.js
View file
Open in desktop
Expand Up @@ -21,7 +21,7 @@ function init() {
}

features.add({
id: 'add-swap-branches-on-compare',
id: 'swap-branches-on-compare',
include: [
features.isCompare
],
Expand Down
2 changes: 1 addition & 1 deletion source/features/add-toggle-files-button.js → source/features/toggle-files-button.js
View file
Open in desktop
Expand Up @@ -29,7 +29,7 @@ function init() {
}

features.add({
id: 'add-toggle-files-button',
id: 'toggle-files-button',
include: [
features.isRepoTree
],
Expand Down
2 changes: 1 addition & 1 deletion source/features/add-trending-menu-item.js → source/features/trending-menu-item.js
View file
Open in desktop
Expand Up @@ -28,7 +28,7 @@ async function init() {
}

features.add({
id: 'add-trending-menu-item',
id: 'trending-menu-item',
exclude: [
features.isGist
],
Expand Down
2 changes: 1 addition & 1 deletion source/features/add-yours-menu-item.js → source/features/yours-menu-item.js
View file
Open in desktop
Expand Up @@ -19,7 +19,7 @@ function init() {
}

features.add({
id: 'add-yours-menu-item',
id: 'yours-menu-item',
include: [
features.isGlobalIssueSearch,
features.isGlobalPRSearch
Expand Down