Distinctly identify commits that refer pull request

[dakshshah96]

Fixes #1579

[fregante]

Can you post a URL where this would appear?

[dakshshah96]

You can take a look at this issue: #226

[fregante]

Bug

This also affects regular references (before/after this PR):

Note

It looks nice, but I don't know if it fixes the issue discussed:

Confusing, looks like the pull request commits and the commit that references this pull request are in the same branch.

I wonder if they should be taken completely off the line (margin-left: 100px):

Also perhaps that blue makes it look more important on the timeline, rather than less important. Maybe we should only use margin-left

cc @sompylasar

[dakshshah96]

I'll try fixing the bug now.

I agree that the blue does make it look more important on the timeline. Only using margin-left seems like a good solution.

[sompylasar]

@bfred-it

I agree with blue vs margin : more-important vs same-importance.

Also some time later after making these styles I noticed that GitHub changed their markup and it became harder-or-impossible-with-CSS-only to determine the conditions for style application.

So reliability of this code has to be tested on a variation of scenarios (the community should definitely have more of them than me alone).

[jerone]

I see the vertical line as a timeline, this can contain commits, but also comments and also references. The reference contains a description and the commit where reference happened. My suggestion would be to combine them by removing the commit icon. Now it's just one reference.

First one has the commit icon removed:

The same is already done when referencing PR:

CSS:

.discussion-item-header[id^='ref-commit-'] + .discussion-item-body .timeline-commits .commit .commit-icon {
	visibility: hidden;
}

[fregante]

My suggestion would be to combine them by removing the commit icon

Yo, that's so smart and obvious that GitHub should pick it up immediately.

@lukehefson plz

---

Combining them is a little harder since they are technically different commits, you're potentially hiding useful information... unless GitHub compares them and groups them instead of completely hiding them; i.e. "2 similar commits" like for collapsed comments: hayaku/hayaku#303 (comment)

[jerone]

Combining them is a little harder

Sorry, I didn't meant to combine them to hide. More semantically combine them by removing the icon.

Is there an example where multiple commits are in one reference? I was thinking, maybe we can indent the commit icon only.

[fregante]

Let's update this to only drop the commit icon and possibly drop the bigger "bookmark" icon to deemphasize it even more.