Conflicts between TypeScript and @typescript-eslint/eslint-plugin

package.json

@@ -57,7 +57,7 @@
 		"@types/react": "^16.8.14",
 		"@types/terser-webpack-plugin": "^1.2.1",
 		"@types/webpack": "^4.4.27",
-		"@typescript-eslint/eslint-plugin": "^1.7.0",
+		"@typescript-eslint/eslint-plugin": "^1.9.0",
 		"ava": "^1.4.0",
 		"chrome-webstore-upload-cli": "^1.2.0",
 		"copy-webpack-plugin": "^5.0.2",

source/features/bypass-checks.tsx

@@ -8,7 +8,7 @@ async function init(): Promise<void> {
 }
 
 async function bypass(check: HTMLElement): Promise<void> {
-	const details = select<HTMLAnchorElement>('.status-actions', check.parentElement!)!;
+	const details = select<HTMLAnchorElement>('.status-actions', check.parentElement)!;
 	const directLink = await fetchDom(details.href, 'a.text-small .octicon-link-external');
 	details.href = (directLink.parentElement as HTMLAnchorElement).href;
 }

source/features/comment-fields-keyboard-shortcuts.tsx

@@ -23,7 +23,7 @@ function init(): void {
 		const field = event.delegateTarget;
 
 		// Don't do anything if the suggester box is active
-		if (select.exists('.suggester:not([hidden])', field.form!)) {
+		if (select.exists('.suggester:not([hidden])', field.form)) {
 			return;
 		}
 
@@ -35,7 +35,7 @@ function init(): void {
 			const cancelButton = select<HTMLButtonElement>(`
 				.js-hide-inline-comment-form,
 				.js-comment-cancel-button
-			`, field.form!);
+			`, field.form);
 
 			// Cancel if there is a button, else blur the field
 			if (cancelButton) {

source/features/copy-file.tsx

@@ -6,7 +6,7 @@ import features from '../libs/features';
 
 function handleClick({currentTarget: button}: React.MouseEvent<HTMLButtonElement>): void {
 	const file = button.closest('.Box');
-	const content = select.all('.blob-code-inner', file!)
+	const content = select.all('.blob-code-inner', file)
 		.map(({innerText: line}) => line === '\n' ? '' : line) // Must be `.innerText`
 		.join('\n');
 	copyToClipboard(content);

source/features/hide-comments-faster.tsx

@@ -4,7 +4,7 @@ import delegate, {DelegateEvent} from 'delegate-it';
 import features from '../libs/features';
 
 function handleMenuOpening(event: DelegateEvent): void {
-	const hideButton = select('.js-comment-hide-button', event.delegateTarget.parentElement!);
+	const hideButton = select('.js-comment-hide-button', event.delegateTarget.parentElement);
 	if (!hideButton) {
 		// User unable to hide or menu already created
 		return;

source/features/highlight-closing-prs-in-open-issues.tsx

@@ -21,7 +21,7 @@ function add(): void {
 				<a
 					href={link}
 					className="btn btn-outline btn-sm border-blue rgh-closing-pr tooltipped tooltipped-se"
-					aria-label={infoBubble.getAttribute('aria-label')!}>
+					aria-label={infoBubble.getAttribute('aria-label')}>
 					{isIssue ? icons.openPullRequest() : icons.commit()}
 					{isIssue ? ' ' + ref.textContent : ''}
 				</a>

source/features/open-all-notifications.tsx

@@ -14,7 +14,7 @@ function openNotifications({delegateTarget}: DelegateEvent): void {
 	const container = delegateTarget.closest('.boxed-group, .notification-center');
 
 	// Ask for confirmation
-	const unreadNotifications = select.all<HTMLAnchorElement>(unreadNotificationsClass, container!);
+	const unreadNotifications = select.all<HTMLAnchorElement>(unreadNotificationsClass, container);
 	if (
 		unreadNotifications.length >= confirmationRequiredCount &&
 		!confirm(`This will open ${unreadNotifications.length} new tabs. Continue?`)
@@ -28,7 +28,7 @@ function openNotifications({delegateTarget}: DelegateEvent): void {
 	});
 
 	// Mark all as read
-	for (const notification of select.all('.unread', container!)) {
+	for (const notification of select.all('.unread', container)) {
 		notification.classList.replace('unread', 'read');
 	}
 
@@ -38,7 +38,7 @@ function openNotifications({delegateTarget}: DelegateEvent): void {
 		.open-repo-notifications,
 		.mark-all-as-read,
 		[href='#mark_as_read_confirm_box']
-	`, container!)) {
+	`, container)) {
 		button.remove();
 	}
 }

source/features/recently-pushed-branches-enhancements.tsx

@@ -11,7 +11,7 @@ const selector = `[data-url='${fragmentURL}'], [src='${fragmentURL}']`;
 // Ajaxed pages will load a new fragment on every ajaxed load;
 // but we only really need the one generated on the first load
 function removeDuplicateList(): void {
-	const duplicate = select(selector, select('main')!);
+	const duplicate = select(selector, select('main'));
 
 	if (duplicate) {
 		duplicate.remove();