New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format selected text in textareas with keyboard shortcuts #2145
Conversation
I saw characters |
Aah, that's right. Forgot to push some changes last night. Thanks for pointing that out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be mentioned in the readme? Are any shortcuts in this file mentioned there?
This PR doesn't exactly add keyboard shortcuts, I don't know if we can call these actions "keyboard shortcuts".
Even if we added it to the readme, what should we call it? ¯\_(ツ)_/¯ |
Yes, should be mentioned in the readme as it's not something most would just discover. |
If you want to extract it into its own feature it could be |
Last time I checked, some of these sub-features weren't working, but that's another issue anyway. There's still the question of what should this be called when including in readme, keyboard shortcut? Or if this should be extracted into its own feature. |
“Format selected text with a key press when writing comments” Perhaps. Not sure about “key press”. Is there an equivalent to “with a click”? |
"Faster text formatting" surround your word or phrase with asterisks. To italicize text, place underscores around a section. This can also be achieved through highlighting the specific word, then pressing the underscore symbol on your keyboard to automatically format the text. Something like this, maybe? |
The formatting is part of GitHub already, so we don’t need to explain that part. |
Closes #2032.
If any text is selected while using these keys, the text is wrapped with each of the pressed characters. Text selection is still preserved so that the user can chain these key presses.
Demo
Test
On any comment textarea for commits or comments.