Meta: Parse feature details at compile time #2167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
commented
Jun 22, 2019
| declare const __featuresList__: string[]; | ||
| declare const __featuresInfo__: FeatureInfo[]; |
There was a problem hiding this comment.
// __featuresList__ in background.js becomes:
[ "add-co-authored-by", "batch-open-issues", "branch-buttons", "bypass-checks", ...]// __featuresInfo__ in options.js becomes:
[ {
name: "add-co-authored-by",
description: "Add co-authors when merging pull requests with multiple committers"
}, {
name: "batch-open-issues",
description: "Open multiple issues in your repo at once"
}, ...
]| @@ -54,5 +54,4 @@ <h2 class="only-firefox">Options</h2> | |||
|
|
|||
| </form> | |||
| <script src="browser-polyfill.min.js"></script> | |||
| <script src="content.js"></script> | |||
| @@ -1,11 +1,35 @@ | |||
| /// <reference types="./source/globals" /> | |||
There was a problem hiding this comment.
This also solves the // @ts-ignore issue below for size-plugin
fregante
commented
Jun 22, 2019
fregante
added a commit
to notlmn/refined-github
that referenced
this pull request
Jun 23, 2019
+ fix apostrophes, refined-github#2167 (comment)
fregante
added a commit
to notlmn/refined-github
that referenced
this pull request
Jun 23, 2019
It will be overwritten by refined-github#2167
|
I'm gonna merge this because I'm having the exact problems that this change is meant to solve. ... but please review this code and maybe #2099 anyway just in case I'm doing something stupid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #2099
This avoids any issues/annoyances caused by loading
content.jsin theoptions.htmlpage.