Easier copy-pasting from diffs by making +/- signs unselectable

[jacobbearden]

So, I had deleted my fork when cleaning up some extraneous repositories I had, so this is all of the changes from, and requested in #254.

This will close #280 if/when it is merged.

[sindresorhus]

Things have changed since last time, make it:

    font-size: 11px;
    text-indent: -8px;

[sindresorhus]

Needs a top: 1px; too. At least on my machine.

[sindresorhus]

There's still a weird problem. Try copy-pasting multiple lines of code from a diff and you'll see that all lines except the first have an extra space at the start of the line.

Example:

td.blob-code.blob-code-deletion:before {
    content: '-';
 }

Notice how the closing brace is indented with one space.

[jacobbearden]

@sindresorhus
I've been looking into the problem you mentioned, and I am having trouble finding a solution.

From what I've looked at it seems to be a problem with how Chrome handles copying text from inline elements, but I'm not sure how to go about counteracting it.

[sindresorhus]

I don't really know either.

// @DrewML Any idea?

[leoj3n]

Maybe this is related?

When I copy the code pictured below (using @jacobbearden's PR):

I get this on my clipboard:

    font-weight: normal;
    margin-left: 4px;
 }
 /* +/- pseudo elements on diffs */
td.blob-code.blob-code-addition:before,
td.blob-code.blob-code-deletion:before {
    display: inline-block;
    position: absolute;
    top: 1px;
    font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace !important;
    font-size: 11px;
    text-indent: -8px;
    color: rgba(0, 0, 0, 0.3);
}
 td.blob-code.blob-code-addition:before {
    content: '+';
}
 td.blob-code.blob-code-deletion:before {
    content: '-';
}

Looks like code outside of (in this case, before) the + diffs has extra space indents that need to be accounted for, and the empty newlines between code blocks are lost. :/

Here is the result with the extension disabled:

    font-weight: normal;
    margin-left: 4px;
  }
 +
 +/* +/- pseudo elements on diffs */
 +td.blob-code.blob-code-addition:before,
 +td.blob-code.blob-code-deletion:before {
 +  display: inline-block;
 +  position: absolute;
 +  top: 1px;
 +  font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace !important;
 +  font-size: 11px;
 +  text-indent: -8px;
 +  color: rgba(0, 0, 0, 0.3);
 +}
 +
 +td.blob-code.blob-code-addition:before {
 +  content: '+';
 +}
 +
 +td.blob-code.blob-code-deletion:before {
 +  content: '-';
 +}

[DrewML]

There's still a weird problem. Try copy-pasting multiple lines of code from a diff and you'll see that all lines except the first have an extra space at the start of the line.

Am I the only person seeing that weird copy/paste behavior even with the extension disabled? It doesn't seem to be this PR that's causing it for me.

1 thing to note (and it sounds crazy, but I've gone through it like 10 times) - When I log out of my GitHub account, the issue goes away. When I log back in, it comes back.

If I visit this diff with refined-github enabled, and copy code from the diff, it works exactly as expected, with no indentation issues.

Edit: This is definitely a GitHub bug. Run $(".add-line-comment").remove() in the console, and then do a copy/paste 😄

[DrewML]

Adding this to content.css seems to fix the issue for me:

.blob-code:not(.is-hovered) .add-line-comment {
    display: none !important;
}

Someone else want to give it a try locally?

[jacobbearden]

@DrewML
Works for me too!

Seems like the issue of blank lines being removed persists though, and a space is being added in place of the \n (before the second td down below):

Copied:

Result:

td.blob-code.blob-code-addition:before {
    content: '+';
}
 td.blob-code.blob-code-deletion:before {
    content: '-';
}

[DrewML]

What do we want to do with this PR? In my opinion, the issue with collapsing empty spaces is still better than what we have without this today (copying all the +/-). Thoughts @sindresorhus @paulmolluzzo @hkdobrev?

[sindresorhus]

Sure. Let's merge it. We can open an issue about improving it in the future if we find a way.

@jacobbearden Could you fix the merge conflict?

[jacobbearden]

@sindresorhus Fixed 😄

[sindresorhus]

I think you had a merge conflict resolve problem here.

[muvaf]

This feature has been removed from Refined Github since it's implemented by Github itself as announced here

However, there are users like myself who use Github Enterprise, which is not updated very frequently. It'd be awesome to have the ability to enable that feature on the preferences page. Neither GHE I'm using supports it nor Refined Github :(

[fregante]

If you're on an older GHE version, it's easier to just use an older RGH. It's too much trouble to support all GHE versions that most of us can't test.

[muvaf]

Is there a documentation on how to use an older version of RGH? Couldn't find an old enough version in Firefox addons.