Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show open-all-notifications on unsaved filters #3087

Merged
merged 1 commit into from May 15, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion source/features/open-all-notifications.tsx
Expand Up @@ -55,7 +55,11 @@ function addOpenReposButton(): void {
}

function addOpenAllButton(): void {
select('.js-check-all-container .Box-header')!.append(
// Selector works on:
// https://github.com/notifications (Grouped by date)
// https://github.com/notifications (Grouped by repo)
// https://github.com/notifications?query=reason%3Acomment (which is an unsaved filter)
select('.js-check-all-container .js-bulk-action-toasts ~ div .Box-header')!.append(
<button className="btn btn-sm rgh-open-notifications-button" type="button">
<LinkExternalIcon className="mr-1"/>Open all unread
</button>
Expand Down