Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show comments-time-machine-links after visiting the link #3135

Merged
merged 3 commits into from May 27, 2020

Conversation

fregante
Copy link
Member

Fixes #1953
Closes #2618
Related to #2131
Ancestor of #1863
Prophecy of #1448 馃獊

Test

To test this feature, click the test links in #2618 (the feature depends on comment date)

Also here are two pre-edited links to see what they look like:

Still exist: https://github.com/sindresorhus/refined-github/blob/master/source/features/comments-time-machine-links.tsx?rgh-link-date=2019-12-11T10%3A12%3A11Z
File deleted: https://github.com/sindresorhus/refined-github/blob/master/source/features/default-to-rich-diff.tsx?rgh-link-date=2019-12-11T10%3A12%3A11Z

Screenshots

If the file still exists, we can also support #1953 by getting the branch name from the page

If the file is deleted, the feature will link to HEAD and hope that the file exists there.

@fregante fregante marked this pull request as ready for review May 25, 2020 13:03
@yakov116

This comment has been minimized.

@fregante

This comment has been minimized.

@fregante fregante merged commit 3e0d92f into master May 27, 2020
@fregante fregante deleted the inconspicuous-timemachine branch May 27, 2020 17:25
@fregante fregante mentioned this pull request Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants