Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint and avoid errors #3256

Merged
merged 18 commits into from Jun 26, 2020
Merged

Lint and avoid errors #3256

merged 18 commits into from Jun 26, 2020

Conversation

yakov116
Copy link
Member

@yakov116 yakov116 commented Jun 19, 2020 •
edited

Yup another one of those

fregante
fregante requested changes Jun 19, 2020
View reviewed changes
source/features/improve-shortcut-help.tsx Show resolved Hide resolved
source/features/bypass-checks.tsx Outdated Show resolved Hide resolved
source/github-helpers/index.ts Show resolved Hide resolved
source/features/comment-fields-keyboard-shortcuts.tsx Outdated Show resolved Hide resolved
@fregante fregante added the meta Related to Refined GitHub itself label Jun 19, 2020
@fregante fregante changed the title Lint and console Lint and avoid errors Jun 19, 2020
yakov116 and others added 2 commits June 19, 2020 11:20
@yakov116 @fregante
Apply suggestions from code review
29fcc50 
Co-authored-by: Fregante <opensource@bfred.it>
@yakov116
Revert Once
6d6530a
@fregante fregante marked this pull request as draft June 20, 2020 11:17
@fregante fregante marked this pull request as ready for review June 21, 2020 22:15
@yakov116 @fregante
Better selector
8a593e8 
Co-authored-by: Fregante <opensource@bfred.it>
@fregante
Copy link
Member

fregante commented Jun 22, 2020 •
edited

Is isRepoHome useful anywhere? We have a couple of features that have weird isRepoRoot/isRepoTree logic.

Same for isRepoCodeTab #3254 (comment)

@yakov116
Copy link
Member Author

Is isRepoHome useful anywhere? We have a couple of features that have weird isRepoRoot/isRepoTree logic.

Probably.

Lets leave it out of this PR. I will go though it maybe tomorrow.

Off Topic. I am out for the day I am swamped with (real) work.

@fregante
Copy link
Member

fregante commented Jun 22, 2020 •
edited

Lets leave it out of this PR.

As for the previous lint PR, let's leave this open and include any small lints in one instead of a new lint PR every few days, unless another PR depends on it.

@yakov116
Copy link
Member Author

yakov116 commented Jun 22, 2020 •
edited

The issue for me is that they get too big / complicated. Also this has 3 fixes in it.

Another point is, you have set a style standard and I think by now we got it straight 😆

@fregante
Copy link
Member

Since this is not a feature PR, adding more lints and console error fixes is totally feasible.

@fregante
Copy link
Member

Looking good!

@fregante fregante merged commit c6c727c into refined-github:master Jun 26, 2020
@yakov116 yakov116 deleted the lint_and_console branch June 26, 2020 12:04
@fregante fregante mentioned this pull request Jul 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fregante fregante fregante approved these changes

Assignees
No one assigned
Labels
meta Related to Refined GitHub itself
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yakov116 @fregante