Meta: Update devDependencies #3451
Conversation
package.json
Outdated
| "mini-css-extract-plugin": "^0.9.0", | ||
| "npm-run-all": "^4.1.5", | ||
| "rollup": "^2.19.0", | ||
| "rollup": "^2.23.1", | ||
| "size-plugin": "^2.0.1", | ||
| "string-replace-loader": "^2.3.0", | ||
| "stylelint": "^13.6.1", | ||
| "stylelint-config-xo": "^0.19.0", | ||
| "terser-webpack-plugin": "^3.0.6", |
There was a problem hiding this comment.
I'm not updating this one yet because in the next version (webpack-contrib/terser-webpack-plugin@100e38e) they start affecting copy-webpack-plugin files too, which means that our neat webextensions.min.js is stripped of license information and unnecessarily "beautified"
I initially used copy-webpack-plugin to copy this file because:
- I want
browserto be a global - I thought AMO preferred unmodified libraries
- It's minified by default!
- It can be used by all entry points without being bundled in each one of them
There are 2 possible solutions to this:
- find/add a way for
terser-webpack-pluginto exclude this file - have webpack create a vendor file
I tried the second one in #3157 already but that failed
There was a problem hiding this comment.
May be possible with https://github.com/webpack-contrib/terser-webpack-plugin#exclude
Let #3451 update it, to avoid conflicts
| "ts-node": "^8.10.2", | ||
| "type-fest": "^0.16.0", | ||
| "typescript": "^3.9.6", |
There was a problem hiding this comment.
TypeScript 4 enables labeled Tuple Types, we can apply these to existing RG code
https://devblogs.microsoft.com/typescript/announcing-typescript-4-0-beta/#labeled-tuple-elements
cc @yakov116
There was a problem hiding this comment.
@fregante can you give me an example? I don't know typescript that well and i am having a hard time understanding how this works.
There was a problem hiding this comment.
microsoft/TypeScript#28259 (comment) Great explanation. 🚀
Comments below