Add stop-pjax-loading-with-esc feature
#3465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artusm
changed the title
stop-pajax-loading-with-esc feature
artusm
changed the title
stop-pajax-loading-with-esc featurestop-pjax-loading-with-esc feature
|
This is honestly much better than I'd have thought, even the profile looks fine. |
Because I've fixed it.
|
fregante
reviewed
Aug 16, 2020
Co-authored-by: Federico <me@fregante.com>
fregante
reviewed
Aug 16, 2020
Co-authored-by: Federico <me@fregante.com>
Co-authored-by: Federico <me@fregante.com>
fregante
reviewed
Aug 19, 2020
fregante
reviewed
Aug 19, 2020
fregante
reviewed
Aug 19, 2020
Co-authored-by: Federico <me@fregante.com>
fregante
approved these changes
Aug 20, 2020
|
We're just waiting for @sindresorhus’s review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LINKED ISSUES:
Closes Stop ajax loading with
esc#2118TEST URLS:
sindresorhus/refined-github
SCREENSHOT:
Known Bugs
Few bugs with profile page after cancelling load on the profile page.(fixed)Browser forward button doesn't work correctly after cancelling load.(fixed)IssueHunt Summary
Referenced issues
This pull request has been submitted to:
esc