Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly dim bot label in dim-bots #3532

Merged
merged 2 commits into from
Sep 8, 2020

Conversation

wilau2
Copy link
Contributor

@wilau2 wilau2 commented Sep 5, 2020

Fix: #3520
@fregante I went a bit fast by approving the change you propose.
This will work a lot better, since there is not / in the URL.

@wilau2 wilau2 changed the title fix: dim label bot fix: dim label bot Sep 5, 2020
@fregante
Copy link
Member

fregante commented Sep 5, 2020

Always provide a link where the PR can be tested, as suggested by the PR template

@fregante fregante added the bug label Sep 5, 2020
@wilau2
Copy link
Contributor Author

wilau2 commented Sep 7, 2020

Here is a link with a repository with the bot label:
https://github.com/wilau2/harvest-balance-calculator/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc
Here is the inspector open on the label:
image

@fregante
Copy link
Member

fregante commented Sep 7, 2020

I think then it should be a more clear label%3Abot

@fregante fregante changed the title fix: dim label bot Correctly dim bot label in dim-bots Sep 7, 2020
@wilau2
Copy link
Contributor Author

wilau2 commented Sep 8, 2020

@fregante updated and tested.

@fregante fregante merged commit 760abcf into refined-github:master Sep 8, 2020
@fregante
Copy link
Member

fregante commented Sep 8, 2020

Thanks! It’s a selector by the way, not a regex 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants