Add new-repo-disable-projects-and-wikis feature
#3539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
reviewed
Sep 10, 2020
fregante
reviewed
Sep 10, 2020
fregante
reviewed
Sep 10, 2020
yakov116
commented
Sep 10, 2020
Co-authored-by: Federico <me@fregante.com>
fregante
reviewed
Sep 10, 2020
fregante
reviewed
Sep 10, 2020
fregante
reviewed
Sep 10, 2020
yakov116
commented
Sep 10, 2020
|
Not sure why typescript is failing |
|
Because it returns a Node, which doesn’t have .remove; it should be an Element. Also make a select-like helper function because 2 consecutive 182-characters lines are obviously not ok. |
This comment has been minimized.
This comment has been minimized.
fregante
reviewed
Sep 10, 2020
fregante
reviewed
Sep 10, 2020
Co-authored-by: Federico <me@fregante.com>
|
@fregante just saying thank you for all your detailed reviews! 🚀 |
|
I think this stopped working and I'm not seeing any related console errors
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LINKED ISSUES:
Closes Automatically disable wiki and project features #3533
TEST URLS:
https://github.com/new
SCREENSHOT: