Improve file-finder-buffer style
#3571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidonng
commented
Sep 17, 2020
fregante
reviewed
Sep 17, 2020
Comment on lines
11
to
12
| className="form-control tree-finder-input p-0 border-0" | ||
| style={{marginTop: '-0.35em', backgroundColor: 'transparent'}} |
There was a problem hiding this comment.
Alignment was not an issue so don't change that.
Suggested change
| className="form-control tree-finder-input p-0 border-0" | |
| style={{marginTop: '-0.35em', backgroundColor: 'transparent'}} | |
| className="form-control tree-finder-input p-0 border-0" | |
| style={{marginTop: '-0.19em', backgroundColor: 'transparent'}} |
This is now misaligned:
There was a problem hiding this comment.
0.35em is the right alignment for me. Could you please try 0.19em with vertical-align: baseline?
fregante
reviewed
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing! 馃崉
LINKED ISSUES:
Close
file-finder-buffer鈥檚 field is now white聽#3212TEST URLS:
https://github.com/sindresorhus/refined-github
SCREENSHOT:
Before:
After: