Extend sticky-conversation-sidebar to also work on the repo home
#3577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves refined-github#3349 Signed-off-by: shine <4771718+shinenelson@users.noreply.github.com>
shinenelson
changed the title
sticky-conversation-sidebar : extend to repository home sidebar
fregante
reviewed
Sep 18, 2020
Signed-off-by: shine <4771718+shinenelson@users.noreply.github.com>
fregante
reviewed
Sep 18, 2020
fregante
reviewed
Sep 18, 2020
shinenelson
force-pushed
the
sticky-repo-sidebar
branch
from
bbc245c
to
02957d4
Compare
Signed-off-by: shine <4771718+shinenelson@users.noreply.github.com>
shinenelson
force-pushed
the
sticky-repo-sidebar
branch
from
02957d4
to
b3dc977
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This reverts commit b3dc977. Signed-off-by: shine <4771718+shinenelson@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
fregante
reviewed
Sep 19, 2020
fregante
approved these changes
Sep 19, 2020
fregante
changed the title
sticky-conversation-sidebar : extend to repository home sidebarsticky-conversation-sidebar to also work on the repo home
fregante
reviewed
Sep 19, 2020
source/features/sticky-sidebar.tsx
Outdated
| @@ -22,10 +26,11 @@ function deinit(): void { | |||
|
|
|||
| void features.add({ | |||
| id: __filebasename, | |||
| description: 'Makes the conversation sidebar sticky.', | |||
| description: 'Makes sidebars sticky.', | |||
There was a problem hiding this comment.
This needs to be updated in the readme as well
Suggested change
| description: 'Makes sidebars sticky.', | |
| description: 'Makes conversation sidebars and repository sidebars sticky, if they fit the viewport.', |
The rest looks good
yakov116
reviewed
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note : this triggers only when the sidebar fits in the viewport height ( just like the conversation sidebar in issues and PRs ). this means that most repositories would fall out of that category because they have too many sections.
LINKED ISSUES:
resolves Scroll sidebar on repositories #3349
TEST URLS:
https://github.com/fregante/Awesome-WebExtensions
SCREENSHOT:
Add a screenshot here if your PR makes visual changes