Avoid repository settings bug caused by stop-pjax-loading-with-esc

[artusm]

1. LINKED ISSUES:
   Closes Edit button doesn't work on repo settings->Webhooks page when using RGH #3584

2. TEST URLS:
   https://github.com/sindresorhus/refined-github/settings/hooks
   https://github.com/REPO_OWNER/REPO_YOU_HAVE_ADMIN_PERMS_ON/settings/hooks

3. SCREENSHOT:
   Add a screenshot here if your PR makes visual changes

[fregante]

It feels like this shouldn't pjaxErrorHandler shouldn't be called at all if the user didn't press esc

I don't remember, why is that needed? What triggers it?

I think the solution is to only add the pjax:error if necessary, once, for example inside keydownHandler instead of in init:

window.addEventListener('pjax:error', pjaxErrorHandler, {once: true});

[artusm]

I don't remember, why is that needed?

https://github.com/sindresorhus/refined-github/blob/a50690c4f5e53820d4c84bd2ecfabe49aab98da7/source/features/stop-pjax-loading-with-esc.tsx#L42

[fregante]

Indeed, but why would it throw? We're just calling history.back()
Does that cause the error?

[artusm]

We're just calling history.back()

which triggers popstate event.

window.addEventListener("popstate", function (t) {
        ut || null == currentPjaxAbortController || currentPjaxAbortController.abort();

which in turn will trigger AbortController.abort().

try {
	const { signal } = (currentPjaxAbortController = new AbortController());
	await fetch(url, { signal } );
} catch (k) {           
    const isPrevented = at(r, "pjax:error");

    if (!isPrevented) {         
       rt && K(null, "", rt.url), window.location.replace(t);
	}
}

Does that cause the error?

When currentPjaxAbortController.abort() is called, the fetch() promise rejects with a DOMException named AbortError.

[fregante]

[Jackenmen]

Thanks for the quick fix and review ❤️