Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop toggle-files-button feature #3587

Closed
wants to merge 6 commits into from
Closed

Drop toggle-files-button feature #3587

wants to merge 6 commits into from

Conversation

roottool
Copy link
Contributor

@roottool roottool commented Sep 21, 2020 •
edited

  1. LINKED ISSUES:
    Closes Hide "Readme" text from repositories #3580

  2. TEST URLS:
    Repository page

  3. SCREENSHOT:
    Before
    before

    After
    After

    GIF
    Drops toggle-files-button feature.

@yakov116
Copy link
Member

yakov116 commented Sep 21, 2020 •
edited

This should also be added to Previously part of Refined GitHub with this as the link

@yakov116 yakov116 changed the title Dropped toggle-files-button Drop toggle-files-button feature Sep 21, 2020
@roottool
Copy link
Contributor Author

@yakov116 Thank you for reviewing my PR. I added the new item to Previously part of Refined GitHub.

fregante
fregante approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

fregante
fregante reviewed Sep 21, 2020
View reviewed changes
readme.md Outdated Show resolved Hide resolved
yakov116
yakov116 reviewed Sep 22, 2020
View reviewed changes
readme.md Outdated Show resolved Hide resolved
@fregante @yakov116
Restore gif
70171c5 
Co-authored-by: yakov116 <16872793+yakov116@users.noreply.github.com>
@cheap-glitch cheap-glitch mentioned this pull request Sep 22, 2020
Closed
@fregante
Copy link
Member

Thanks for the PR @roottool, unfortunately we're probably not doing to drop the feature after all, because

I agree, the reason we wanted to drop the feature was due to the Readme link already existing. However even that, only exists on the root of the repository.

#3588 (comment)

@fregante fregante closed this Sep 22, 2020
@roottool roottool deleted the drop-toggle-files-button#3580 branch September 22, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fregante fregante fregante approved these changes

@yakov116 yakov116 yakov116 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide "Readme" text from repositories
3 participants
@roottool @yakov116 @fregante