Focus field after using collapsible-content-button
#3600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Am I crazy or are the two gifs the same? |
No, in the second one the text stays selected. |
|
Thanks! Can you always .focus before the .insert? If a field is not focused, that .insert will focus it and then restore the focus back to where it was. |
Done! |
fregante
approved these changes
Sep 29, 2020
fregante
changed the title
<details> tagcollapsible-content-button
kidonng
pushed a commit
to kidonng/refined-github
that referenced
this pull request
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing! 🍄
LINKED ISSUES: none
TEST URLS: https://github.com/sindresorhus/refined-github/issues/new
While working on #3598 I noticed a small bug in
collapsible-content-button.tsx: there was a few lines of code to restore the selection after wrapping it in a<details>tag, but it had no effect (at least on latest Firefox):This can be fixed by focusing the textarea before restoring the selection:
