Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid errors caused by more-dropdown on issues #3653

Merged
merged 12 commits into from
Oct 18, 2020
Merged

Conversation

yakov116
Copy link
Member

Co-authored-by: Federico <me@fregante.com>
@yakov116 yakov116 added the bug label Oct 15, 2020
@yakov116
Copy link
Member Author

@fregante when you approve can I assume the title is good?

Co-authored-by: Federico <me@fregante.com>
Co-authored-by: Federico <me@fregante.com>
@fregante
Copy link
Member

Just fix the type issue with ! or something.

I checked all the features where we use GitHubURL and all of them have a branch. In forked-to we specifically avoid errors by limiting the usage of GitHubURL to pages with a branch, even if the feature is enabled on isRepo https://github.com/sindresorhus/refined-github/blob/d7d700a20befb552f9f64e15504b845dbe04e699/source/features/forked-to.tsx#L34-L36

In another feature we also specifically mention the incompatibility so we don't use GitHubURL:
https://github.com/sindresorhus/refined-github/blob/b7d31c6ae88ce48f4f5fa2716716a40e32eeea1b/source/features/comments-time-machine-links.tsx#L77

@fregante
Copy link
Member

fregante commented Oct 17, 2020

@fregante when you approve can I assume the title is good?

Not always. Generally try to make the commit titles readable by users. "returns undefined" doesn't explain how this helps the user. In this case the specific user-facing bug being solved is Avoid errors caused by `more-dropdown` on issues or Fix XYZ link in `more-dropdown` on issues or something along those lines

@yakov116 yakov116 changed the title getCurrentBranch() Return undefined if branch is indeterminable Avoid errors caused by more-dropdown on issues Oct 18, 2020
@yakov116 yakov116 merged commit 6a8fda9 into master Oct 18, 2020
@yakov116 yakov116 deleted the getCurrentBranch branch October 18, 2020 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

GetCurrentBranch Stopped working on issues
3 participants