-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid errors caused by more-dropdown
on issues
#3653
Conversation
Co-authored-by: Federico <me@fregante.com>
Co-authored-by: Laxman <bytemode@outlook.com>
@fregante when you approve can I assume the title is good? |
Co-authored-by: Federico <me@fregante.com>
Co-authored-by: Federico <me@fregante.com>
Just fix the type issue with I checked all the features where we use GitHubURL and all of them have a branch. In In another feature we also specifically mention the incompatibility so we don't use GitHubURL: |
Not always. Generally try to make the commit titles readable by users. "returns undefined" doesn't explain how this helps the user. In this case the specific user-facing bug being solved is |
Co-authored-by: Federico <me@fregante.com>
getCurrentBranch()
Return undefined if branch is indeterminablemore-dropdown
on issues
LINKED ISSUES:
Fixes
GetCurrentBranch
Stopped working on issues #3641TEST URLS:
GetCurrentBranch
Stopped working on issues #3641SCREENSHOT:
None