Fix profile-hotkey on Gist pages

[yakov116]

1. LINKED ISSUES:
   None

2. TEST URLS:
   https://gist.github.com/yakov116

3. SCREENSHOT:
   None

It did not work there since /${getUsername() leads to the Your gists button

[notlmn]

Can this be?

Suggested change

	const menuItem = select.last(`[aria-label="View profile and more"] ~ details-menu a[href$="/${getUsername()}"]`);
	const menuItem = select.last(`[aria-label="View profile and more"] ~ details-menu a[href^="/${getUsername()}"]`);

I mean, both work, but I'm a bit inclined towards ^ for no specific reason.

[yakov116]

No. The url on the gist page is https://github.com/yakov116
/${getUsername() = https://gist.github.com/yakov116 Which is the link it was catching until not. Hence this PR.

[yakov116]

Updated the PR description

[fregante]

But in reality this was pretty simple:

Suggested change

	const menuItem = select.last(`[aria-label="View profile and more"] ~ details-menu a[href$="/${getUsername()}"]`);
	select('a[data-ga-click$="text:your profile"]')!.dataset.hotkey = 'g m';

We don't even need the check. All users have a profile. RG is only expected to work on logged in users.

[notlmn]

RG is only expected to work on logged in users.

Yes, but at least we can fail gracefully. Would help us as well, if all of a sudden GitHub decides to change class names and other stuff, we can still fail gracefully.

BUT that would beg the question of how we would be able to detect a failure. Errors is how we get most of the reports from users, raising issues.

[yakov116]

But in reality this was pretty simple:

OMG how did I not catch that?!

[fregante]

Yes, but at least we can fail gracefully.

Nah. Do you really wanna check all the features on logged out pages? I don’t. That’s why we display a warning in that case.

if all of a sudden GitHub decides to change class names and other stuff, we can still fail gracefully.

Unless a feature has the potential to lose data or break native functionality, we don’t need that. At most we display an alert if the feature is a complex action like restore-files

In this case, the previous code silently failed until Yakov went testing all the features; it’s better it let the error appear in the console so someone fixes it.

[yakov116]

do ga's work on enterprise?

[fregante]

That’s a good question. We use them in a few features and nobody complained though

[fregante]

Let's merge this in the meanwhile. We can decide later what we can do about GHE support (if anything)