Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop remove-checks-tab feature #3676

Merged
merged 2 commits into from
Oct 21, 2020
Merged

Drop remove-checks-tab feature #3676

merged 2 commits into from
Oct 21, 2020

Conversation

arnaudvalle
Copy link
Contributor

Thanks for contributing! 馃崉

  1. LINKED ISSUES:
    Closes Drop remove-checks-tab feature or make it dynamic聽#3667

  2. TEST URLS:
    Go to a PR page (like this one) and see that the "Checks" tab is always displayed, even when there are 0 checks.
    added code so button is flush with rightside of containing box聽algobook/algoBook#9

  3. SCREENSHOT:

@yakov116 yakov116 changed the title Drop remove checks tab feature Drop remove-checks-tab feature Oct 21, 2020
@yakov116 yakov116 merged commit a38244e into refined-github:master Oct 21, 2020
@yakov116
Copy link
Member

Thanks for contributing!

@arnaudvalle
Copy link
Contributor Author

Thanks for contributing!

You're welcome. Always happy to remove some code 馃槈

@arnaudvalle arnaudvalle deleted the chore/drop-remove-checks-tab branch October 22, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fregante fregante fregante approved these changes

@yakov116 yakov116 yakov116 approved these changes

Assignees
No one assigned
Labels
change request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop remove-checks-tab feature or make it dynamic
3 participants
@arnaudvalle @yakov116 @fregante