Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore faster-reviews autofocus #3681

Merged
merged 3 commits into from
Oct 23, 2020
Merged

Restore faster-reviews autofocus #3681

merged 3 commits into from
Oct 23, 2020

Conversation

FloEdelmann
Copy link
Member

As mentioned in #3621. You can test it right here in this PR 馃槈

@yakov116 yakov116 added the bug label Oct 22, 2020
@fregante fregante self-requested a review October 22, 2020 22:42
@fregante
Copy link
Member

fregante commented Oct 22, 2020 •
edited

I think this is a GitHub bug we could wait to be fixed.

This feature merely mirrors the native "Add your review" button that appears when someone requests your review:

@FloEdelmann
Copy link
Member Author

FloEdelmann commented Oct 23, 2020 •
edited

I use it all the time, that's why I wanted to fix it. For quite some time now we are adding the "review now" button for no good reason, it leads to exactly the same page/state as the "Files" tab does.

This feature merely mirrors the native "Add your review" button that appears when someone requests your review

I didn't know about that other place where the link is used as well. So maybe GitHub has actually an incentive to fix it themselves.

@fregante
Copy link
Member

Alternatively, this could be implemented as an additional init in the same file so that it fixes the native #submit-review hash as well.

@FloEdelmann
Copy link
Member Author

I've changed it back to #submit-review.

could be implemented as an additional init in the same file

Why an additional init?

@fregante fregante merged commit 05de5a5 into refined-github:master Oct 23, 2020
@FloEdelmann FloEdelmann deleted the fix-faster-reviews branch October 23, 2020 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fregante fregante fregante approved these changes

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FloEdelmann @fregante @yakov116