Add jump-to-change-requested-comment feature
#3710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! That area of the page is updated via ajax, so it needs to use |
|
I updated the feature to use |
fregante
reviewed
Nov 10, 2020
fregante
requested changes
Nov 10, 2020
fregante
reviewed
Nov 10, 2020
Comment on lines
16
to
18
| if (element) { | ||
| wrap(element, <a href={messageContainer.href}/>); | ||
| } |
There was a problem hiding this comment.
Conditions like this makes any future errors silent, however this element is expected to be "not found" when GitHub starts hiding some comments on long discussions.
It's not ideal, but we don't have a reasonable solution here.
fregante
changed the title
link-to-requested-change-comment featurelink-to-requested-change-comment feature
yakov116
reviewed
Nov 11, 2020
xtianatilano
changed the title
link-to-requested-change-comment featurejump-to-change-requested-comment feature
fregante
changed the title
jump-to-change-requested-comment featurejump-to-change-requested-comment feature
Thank you! 馃コ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing! 馃崉
LINKED ISSUES:
Closes #2712
TEST URLS:
#17968
SCREENSHOT: