Fix first-commit-message-for-new-prs
#3722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
reviewed
Nov 13, 2020
| '[href="#commits_bucket"] .Counter' // Same repository | ||
| ].join()); | ||
| const commitsBucket = await elementReady<HTMLElement>('#commits_bucket'); | ||
| const commitCount = commitsBucket?.previousElementSibling?.querySelector('ul > li:nth-child(1) .text-emphasized'); |
There was a problem hiding this comment.
Yes testing link in first post
There was a problem hiding this comment.
Use octicon-git-commit to select this
There was a problem hiding this comment.
What did you test exactly? Neither one of those commits have a description
There was a problem hiding this comment.
Your right I did not test the description part but the title changes. Will test it soon.
Co-Authored-By: Fregante <opensource@bfred.it>
fregante
reviewed
Nov 16, 2020
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub is going to give us a very hard time. There are almost no more class specific selectors
Test on:
https://github.com/sindresorhus/refined-github/compare/master...yakov116:text?expand=1 (Cross-fork)
https://github.com/sindresorhus/refined-github/compare/master...sindresorhus:lint?expand=1 (Same-repo)