-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid duplicate upload button in minimize-upload-bar
#3724
Avoid duplicate upload button in minimize-upload-bar
#3724
Conversation
48f950e
to
d94671c
Compare
Thanks for the PR! Both buttons do the same thing, so our button should also be removed. Additionally, this should be part of |
d285669
to
a5391e2
Compare
@fregante sorry for misunderstanding. updated. |
Much better, thanks! From what I see, this feature can be simplified further:
|
About 2: the previous selectors probably don’t need to be updated at all |
|
Our class needs to be added on body. Then that form class needs to be used to select the form in your new selector. The number of forms changes on the page, so the loop will not include all of them. |
@fregante Thank you for reviewing. I have tried to address the problem. Can you check if I have understood correctly? |
Looks about right! |
.rgh-minimize-upload-bar .js-previewable-comment-form label[aria-label='Attach an image'] { | ||
display: block !important; | ||
padding: 4px !important; | ||
margin: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has no effect and is not necessary
margin: 0; |
minimize-upload-bar
LINKED ISSUES:
Closes Reuse GitHub’s native upload button in
minimize-upload-bar
#3714TEST URLS:
Avoid duplicate upload button in
minimize-upload-bar
#3724SCREENSHOT:
edit: update screenshots
image for readme: